Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New user properties for Analytics [WPB-16121] #3890

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

borichellow
Copy link
Contributor

@borichellow borichellow commented Feb 25, 2025

TaskWPB-16121 [Android] Implement new user properties

What's new in this PR?

New user properties for Countly: team_is_enterprise, team_is_team, team_team_id, team_team_size, user_contacts.

Solutions

Use new kalium UseCase for getting combined AnalyticsContactsData and provide that values to Countly.

Waiting for wireapp/kalium#3312 be merged.

Copy link
Contributor

@borichellow looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
2a940f7f2f3cd2996c2b8100caf64893f7804529 389894b9342afd1a77e3550b2f9f57ae2c29c372

Is this intentional?

Copy link
Contributor

@borichellow looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
2a940f7f2f3cd2996c2b8100caf64893f7804529 96cfab54bf45905c8240a59e42b0bb2320e3ddbc

Is this intentional?

Copy link
Contributor

@borichellow looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
2a940f7f2f3cd2996c2b8100caf64893f7804529 96cfab54bf45905c8240a59e42b0bb2320e3ddbc

Is this intentional?

Copy link

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.

Project coverage is 45.61%. Comparing base (5d2f286) to head (fcaf42b).

Files with missing lines Patch % Lines
...rc/main/kotlin/com/wire/android/WireApplication.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3890      +/-   ##
===========================================
+ Coverage    45.58%   45.61%   +0.03%     
===========================================
  Files          491      491              
  Lines        17071    17079       +8     
  Branches      2849     2848       -1     
===========================================
+ Hits          7781     7790       +9     
  Misses        8495     8495              
+ Partials       795      794       -1     
Files with missing lines Coverage Δ
...analytics/ObserveCurrentSessionAnalyticsUseCase.kt 88.63% <100.00%> (+5.30%) ⬆️
...rc/main/kotlin/com/wire/android/WireApplication.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d2f286...fcaf42b. Read the comment docs.

Copy link
Contributor

Built wire-android-staging-compat-pr-3890.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3890.apk is available for download

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants